Staraptor Lv.49
-Fly
-Endeavor
-Brave Bird
-Aerial Ace
The first thing you want to do is to remove most of your HMs from your team. Staraptor certainly needs to lose Fly - it's a two-turn move and useless in comparison to Aerial Ace. Personally, I feel that Aerial Ace, which never misses is superior to Brave Bird, which can miss if the opponent is highly evasive
and causes you to take 1/3 recoil damage - but that's your choice.
Staraptor is vulnerable to Electric, Ice and Rock attacks, so you want to try to cover for these weaknesses. Fighting covers both Ice and Rock, so I'd put on Close Combat which it learns by level up. (If you missed it, use a Heart Scale at the Move Tutor in Pastoria). Nothing you can do about Electric, but put a good general move on. I might actually recommend that you choose a second Normal move (!!) because Endeavor is one of those attacks that depends on your current HP. Return or Facade would be a better general attack.
Not commenting on Giratina because I don't do legendaries generally.
[quote author=superlugia1 link=topic=6445.msg112194#msg112194 date=1246889743]
Golduck Lv.43
-Surf
-Water Pulse
-Confusion
-Water Gun
[/quote]
Golduck needs to lose Water Gun and either Surf or Water Pulse. Personally, I don't like the fact that in Gen 4, Surf now hits your own Pokemon, so I'd go with Water Pulse if I wanted the confusion effect, or Brine (TM). It's usual to put an Ice-type move on Water-type Pokemon, so if you're going with Special moves, try Ice Beam. Kinda struggling for a fourth move here, so you could go for Calm Mind, Protect or Endure (to boost your own stats/keep yourself alive), or Toxic to be annoying.
NOTE: I haven't looked at the TM locations to see whether you can get all of these TMs pre-E4, you'll need to check that.
[quote author=superlugia1 link=topic=6445.msg112194#msg112194 date=1246889743]
Torterra Lv.45
-Sythesis
-Earthquake
-Crunch
-Razor Leaf
[/quote]
Earthquake is good. Crunch isn't bad (though it doesn't cover any of Torterra's weaknesses). Razor Leaf is pretty meh... a great move at low level, but not ideal at level 45+. Looks like you're stuck with it, unless you want to use a Heart Scale to learn Wood Hammer. It's much more powerful, but loses 1/3 recoil damage.
My Torterra is going to have a Rock move as this is supereffective against ALL of its weaknesses - Fire, Ice, Flying and Bug! There are several Rock TMs, choose the power and accuracy combination you think you can live with.
[quote author=superlugia1 link=topic=6445.msg112194#msg112194 date=1246889743]
Drifblim Lv.42
-Gust
-Shadow Ball
-Ominous Wind
[/quote]
Three moves isn't great ;D.
My Drifblim has Silver Wind for the fourth move, and also Thunderbolt.
[quote author=superlugia1 link=topic=6445.msg112194#msg112194 date=1246889743]
Any suggestions?
[/quote]
Finally, you need to think about hold items. They are as important as the moveset.